Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

[pvr.hts] Fix dvr delete response timeout value. Must be msecs, not secs... #421

Merged
merged 1 commit into from
Jan 28, 2015
Merged

[pvr.hts] Fix dvr delete response timeout value. Must be msecs, not secs... #421

merged 1 commit into from
Jan 28, 2015

Conversation

ksooo
Copy link
Contributor

@ksooo ksooo commented Jan 27, 2015

Followup to #415.

@Jalle19: Yesterday I've learned from Kodi that deleting recordings within 30 msecs is not really working. ;-)

@Jalle19
Copy link
Collaborator

Jalle19 commented Jan 27, 2015

Good catch, thanks!

@ksooo
Copy link
Contributor Author

ksooo commented Jan 27, 2015

Slightly improved.

Jalle19 added a commit that referenced this pull request Jan 28, 2015
[pvr.hts] Fix dvr delete response timeout value. Must be msecs, not secs...
@Jalle19 Jalle19 merged commit 715acce into opdenkamp:master Jan 28, 2015
@opdenkamp
Copy link
Owner

@Jalle19 no more merging in PRs here until we've got the binary add-on PR in please.

@opdenkamp
Copy link
Owner

this PR isn't right anyway, you should not be checking settings input here.

@opdenkamp
Copy link
Owner

so remove the std::max stuff

@Jalle19
Copy link
Collaborator

Jalle19 commented Jan 28, 2015

@opdenkamp what do you mean? We want to use a 30 second timeout unless the configured response timeout is larger than that.

@Jalle19
Copy link
Collaborator

Jalle19 commented Jan 28, 2015

I'll port the fix once the addons have been transitioned to their new homes, don't worry.

@opdenkamp
Copy link
Owner

so you can configure a > 30 sec timeout in settings but won't use it in this situation? why?

and no merging in new ones as discussed in the other PR. this repos is frozen now except for changes in previous branches.

edit: typo

@ksooo ksooo deleted the fix-pvr-delete-response-timeout branch January 28, 2015 10:44
@ksooo
Copy link
Contributor Author

ksooo commented Jan 28, 2015

so you can configure a > 30 sec timeout in settings but won't use it in this situation? why?
For the records: The idea is exactly to use the settings value if it is > 30 secs

this PR isn't right anyway, you should not be checking settings input here.
Why? Settings are used at several places in Tvheadend class. It even has a member m_settings (which, btw I should have use instead of tvh->GetSettings()).
- std::max(30000, tvh->GetSettings().iResponseTimeout))) == NULL)
+ std::max(30000, m_settings.iResponseTimeout))) == NULL)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants