[pvr.nextpvr] Added support for ATSC subchannel numbers, fixing 'no tuner available' m...

[sub3]

Added support for ATSC subchannel numbers, fixing 'no tuner available' message users were getting with this type of channel
Fixes a problem with playback of radio stations
Added recording artwork
Added fanart

[Jalle19]

Is the intention to get this included for Helix?

[Jalle19]

Needs a rebase as well.

[sub3]

Yes, including in Helix was my intention.

[Jalle19]

Okay, if you rebase I can pull it in.

[sub3]

I've rebased this. Please go ahead an pull it in. Thanks!

[sub3]

Can you tell me when this will be merged? I really want these bug fixes included.

[Jalle19]

It'll have to wait until the first Helix point release, we need to focua on getting Helix out the door.

[sub3]

What do I need to do to get this included in Helix now, instead of waiting for the point release? The first two changes are bug fixes, and causing significant issues for users of ATSC tuners and those using DVB radio. The other two changes are very minor. I can rebase this again to resolve the conflicts with more recent changes. I think it's unfair on NextPVR users to not include this.

[Jalle19]

@opdenkamp you decide

[sub3]

I've rebased this again, so that it includes later changes from the upstream opdenkamp repository.

[opdenkamp]

meh, something broke this PR again. needs another rebase, sorry.

[sub3]

OK, I've rebased this again.

[opdenkamp]

will merge this in asap, but will do #372 first. will probably merge these open PRs locally and push the result so we don't need a load of rebases again

[sub3]

Ok thanks. Let me know if you need me to do anything.

[sub3]

Hi Lars. Just to be clear - this is going to show up in 14.1 right?

On 13/01/2015 1:09 p.m., Lars Op den Kamp wrote:

Merged #384 #384.

—
Reply to this email directly or view it on GitHub
#384 (comment).

[Jalle19]

@sub3 you'll need to create a corresponding PR to the "helix" branch (which got added today).

[sub3]

You've got be f*cking kidding me. Are you guys intentionally trying to make life difficult for me? I've been trying to get this small code change, which fixes problems for NextPVR ATSC users, merged for like 2 months now.

[sub3]

Sorry about above - just frustrated. I'll create a new helix branch and pull request later today.

[opdenkamp]

"master" is always for the upcoming release

[sub3]

"helix" was the upcoming release way back when I created the pull request...

[opdenkamp]

and unfortunately we were already in beta by that time.

[sub3]

and a serious bug effecting all ATSC users can't be fixed in beta?

[opdenkamp]

the "serious bug" must be on the backend's side then, expecting
subchannel numbers in the url that it didn't expect before.
also, using the channel number for tuning is not a good idea. you should
be using the channel id instead. your add-on will break if users don't
have "use backend channel numbers" enabled.

On 15-01-15 02:44, sub3 wrote:

and a serious bug effecting all ATSC users can't be fixed in beta?

—
Reply to this email directly or view it on GitHub
#384 (comment).

[sub3]

That's your implementation recommendation, but either way, whether I'd chose to change the addon to use the channel id, or the major.minor number, I would still have needed to submit a change to the addon. I opted for the major.minor number, because this Kodi addon is just reusing streaming interface that is supposed to be human usable from apps like VLC etc, where the user wont know channel ids, but will know channel numbers.

I'll submit the pull request for helix today.

[opdenkamp]

I've never recommended to use channel numbers for anything like this. I
still don't, as it's something that breaks when people change the order
on one frontend, or use different channel numbers on that frontend, or
whatever.

There were no minor channel numbers until a couple of months ago when I
added it, and your add-on didn't change in the meantime. So the reason
for suddenly requiring those minor channel numbers must have come from
an update on the backend's side. Which probably also means that the
backend no longer supports Gotham or older.

On 15-01-15 21:12, sub3 wrote:

That's your implementation recommendation, but either way, whether I'd
chose to change the addon to use the channel id, or the major.minor
number, I would still have needed to submit a change to the addon. I
opted for the major.minor number, because this Kodi addon is just
reusing streaming interface that is supposed to be human usable from
apps like VLC etc, where the user wont know channel ids, but will know
channel numbers.

I'll submit the pull request for helix today.

—
Reply to this email directly or view it on GitHub
#384 (comment).