Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for resources and groups #27

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

jan-opal
Copy link
Contributor

Description of the change

Adds data sources for resources and groups. Currently the only way to retrieve them is via the Opal ID. A possible later addition could be to allow doing this via things like:

  1. name + resource type (fail if no unique result)
  2. remote info (i.e. AWS ARN, Okta group ID, etc)

But for now this matches the pattern of the app data source and in a previous PR we also added the Opal IDs in the UI with easy click to copy button to make using these easier.

Testing

  • tested fetching both group and resources via the IDs and using their attributes in other places

Checklist

  • I performed a self-review of my code
  • I manually tested my code change (please list details in description)
  • I added unit tests
  • I updated the changelog
  • I updated the public facing docs

@linear
Copy link

linear bot commented Aug 28, 2023

@jan-opal jan-opal temporarily deployed to Test August 28, 2023 18:41 — with GitHub Actions Inactive
@jan-opal jan-opal requested review from a team and ken-opal August 28, 2023 18:41
opal/group.go Outdated Show resolved Hide resolved
@jan-opal jan-opal temporarily deployed to Test August 29, 2023 14:21 — with GitHub Actions Inactive
@jan-opal jan-opal temporarily deployed to Test August 29, 2023 14:21 — with GitHub Actions Inactive
@jan-opal jan-opal merged commit afe64c1 into main Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants