Skip to content

Commit

Permalink
cuGraph code cleanup (rapidsai#2431)
Browse files Browse the repository at this point in the history
Moved files to the legacy directory and delete unused code.

Breaking because legacy public headers are deleted/moved/modified.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Brad Rees (https://github.com/BradReesWork)

URL: rapidsai#2431
  • Loading branch information
seunghwak authored Jul 25, 2022
1 parent efc05b3 commit d6b4cc5
Show file tree
Hide file tree
Showing 31 changed files with 31 additions and 175 deletions.
6 changes: 3 additions & 3 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ set(CUGRAPH_SOURCES
src/traversal/legacy/bfs.cu
src/link_prediction/jaccard.cu
src/link_prediction/overlap.cu
src/layout/force_atlas2.cu
src/converters/COOtoCSR.cu
src/layout/legacy/force_atlas2.cu
src/converters/legacy/COOtoCSR.cu
src/community/legacy/spectral_clustering.cu
src/community/louvain_sg.cu
src/community/louvain_mg.cu
Expand All @@ -206,7 +206,7 @@ set(CUGRAPH_SOURCES
src/cores/core_number_sg.cu
src/cores/core_number_mg.cu
src/traversal/two_hop_neighbors.cu
src/components/connectivity.cu
src/components/legacy/connectivity.cu
src/centrality/betweenness_centrality.cu
src/generators/generate_rmat_edgelist.cu
src/generators/generator_tools.cu
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cugraph/algorithms.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
#include <cugraph/graph.hpp>
#include <cugraph/graph_view.hpp>

#include <cugraph/internals.hpp>
#include <cugraph/legacy/graph.hpp>
#include <cugraph/legacy/internals.hpp>

#ifndef NO_CUGRAPH_OPS
#include <cugraph-ops/graph/sampling.hpp>
Expand Down
45 changes: 0 additions & 45 deletions cpp/include/cugraph/eidir_graph.hpp

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -64,4 +64,5 @@ void comms_bcast(const raft::handle_t& handle, value_t* value, size_t count)
{
handle.get_comms().bcast(value, count, 0, handle.get_stream());
}

} // namespace cugraph
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
1 change: 0 additions & 1 deletion cpp/src/community/legacy/ecg.cu
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

#include <community/legacy/louvain.cuh>
#include <converters/permute_graph.cuh>
#include <cugraph/algorithms.hpp>
#include <cugraph/utilities/error.hpp>
#include <utilities/graph_utils.cuh>
Expand Down
2 changes: 0 additions & 2 deletions cpp/src/community/legacy/louvain.cu
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,3 @@ template std::pair<size_t, double> louvain(raft::handle_t const&,
size_t,
double);
} // namespace cugraph

#include <cugraph/legacy/eidir_graph.hpp>
2 changes: 1 addition & 1 deletion cpp/src/community/legacy/louvain.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

#include <cugraph/legacy/graph.hpp>

#include <converters/COOtoCSR.cuh>
#include <converters/legacy/COOtoCSR.cuh>
#include <utilities/graph_utils.cuh>

#include <cugraph/dendrogram.hpp>
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -15,7 +15,6 @@
*/

#include "COOtoCSR.cuh"
#include <cugraph/functions.hpp>

namespace cugraph {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include <cub/device/device_radix_sort.cuh>
#include <cub/device/device_run_length_encode.cuh>

#include <cugraph/functions.hpp>
#include <cugraph/legacy/functions.hpp>

#include <cugraph/legacy/graph.hpp>

Expand Down
96 changes: 0 additions & 96 deletions cpp/src/converters/permute_graph.cuh

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
#include "fa2_kernels.cuh"
#include "utils.hpp"

#include <converters/COOtoCSR.cuh>
#include <converters/legacy/COOtoCSR.cuh>
#include <utilities/graph_utils.cuh>

#include <cugraph/detail/utility_wrappers.hpp>
#include <cugraph/internals.hpp>
#include <cugraph/legacy/graph.hpp>
#include <cugraph/legacy/internals.hpp>
#include <cugraph/utilities/error.hpp>

#include <rmm/device_uvector.hpp>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
#include <rmm/device_uvector.hpp>
#include <rmm/exec_policy.hpp>

#include <converters/COOtoCSR.cuh>
#include <converters/legacy/COOtoCSR.cuh>

#include <cugraph/detail/utility_wrappers.hpp>
#include <cugraph/internals.hpp>
#include <cugraph/legacy/graph.hpp>
#include <cugraph/legacy/internals.hpp>
#include <cugraph/utilities/error.hpp>

#include <thrust/fill.h>
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions cpp/tests/components/con_comp_test.cu
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2021, NVIDIA CORPORATION. All rights reserved.
* Copyright (c) 2019-2022, NVIDIA CORPORATION. All rights reserved.
*
* NVIDIA CORPORATION and its licensors retain all intellectual property
* and proprietary rights in and to this software, related documentation
Expand All @@ -20,7 +20,7 @@

#include <rmm/device_vector.hpp>

#include <converters/COOtoCSR.cuh>
#include <converters/legacy/COOtoCSR.cuh>
#include <cugraph/algorithms.hpp>
#include <cugraph/legacy/graph.hpp>

Expand Down
4 changes: 2 additions & 2 deletions cpp/tests/components/scc_test.cu
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

#include <rmm/device_vector.hpp>

#include <components/scc_matrix.cuh>
#include <converters/COOtoCSR.cuh>
#include <components/legacy/scc_matrix.cuh>
#include <converters/legacy/COOtoCSR.cuh>
#include <cugraph/algorithms.hpp>
#include <cugraph/legacy/graph.hpp>
#include <rmm/device_vector.hpp>
Expand Down
2 changes: 1 addition & 1 deletion cpp/tests/tree/mst_test.cu
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

#include <cmath>

#include "../src/converters/COOtoCSR.cuh"
#include "../src/converters/legacy/COOtoCSR.cuh"
#include <thrust/device_ptr.h>
#include <thrust/iterator/constant_iterator.h>
#include <thrust/reduce.h>
Expand Down
2 changes: 1 addition & 1 deletion cpp/tests/utilities/matrix_market_file_utilities.cu
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
#include <detail/graph_utils.cuh>
#include <utilities/test_utilities.hpp>

#include <cugraph/functions.hpp>
#include <cugraph/graph_functions.hpp>
#include <cugraph/legacy/functions.hpp>
#include <cugraph/partition_manager.hpp>
#include <cugraph/utilities/error.hpp>

Expand Down
2 changes: 1 addition & 1 deletion cpp/tests/utilities/test_graphs.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@

#include <cugraph/detail/shuffle_wrappers.hpp>
#include <cugraph/detail/utility_wrappers.hpp>
#include <cugraph/functions.hpp> // legacy coo_to_csr
#include <cugraph/graph_functions.hpp>
#include <cugraph/graph_generators.hpp>
#include <cugraph/legacy/functions.hpp> // legacy coo_to_csr

#include <utilities/test_utilities.hpp>
#include <utilities/thrust_wrapper.hpp>
Expand Down
4 changes: 2 additions & 2 deletions python/cugraph/cugraph/internals/callbacks_implems.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -17,7 +17,7 @@
#pragma once

#include <Python.h>
#include <cugraph/internals.hpp>
#include <cugraph/legacy/internals.hpp>

#include <iostream>

Expand Down
4 changes: 2 additions & 2 deletions python/cugraph/cugraph/layout/force_atlas2.pxd
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020-2021, NVIDIA CORPORATION.
# Copyright (c) 2020-2022, NVIDIA CORPORATION.
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Expand All @@ -19,7 +19,7 @@
from cugraph.structure.graph_primtypes cimport *
from libcpp cimport bool

cdef extern from "cugraph/internals.hpp" namespace "cugraph::internals":
cdef extern from "cugraph/legacy/internals.hpp" namespace "cugraph::internals":
cdef cppclass GraphBasedDimRedCallback

cdef extern from "cugraph/algorithms.hpp" namespace "cugraph":
Expand Down
4 changes: 2 additions & 2 deletions python/cugraph/cugraph/layout/force_atlas2_wrapper.pyx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020-2021, NVIDIA CORPORATION.
# Copyright (c) 2020-2022, NVIDIA CORPORATION.
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Expand All @@ -25,7 +25,7 @@ import cudf
from numba import cuda
import numpy as np

cdef extern from "cugraph/internals.hpp" namespace "cugraph::internals":
cdef extern from "cugraph/legacy/internals.hpp" namespace "cugraph::internals":
cdef cppclass GraphBasedDimRedCallback


Expand Down
Loading

0 comments on commit d6b4cc5

Please sign in to comment.