Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine, miniooni: handle OONI Run v2 integer options #2645

Closed
bassosimone opened this issue Dec 13, 2023 · 0 comments · Fixed by ooni/probe-cli#1435
Closed

engine, miniooni: handle OONI Run v2 integer options #2645

bassosimone opened this issue Dec 13, 2023 · 0 comments · Fixed by ooni/probe-cli#1435
Assignees
@bassosimone
Labels
bug Something isn't working funder/mozilla2023 ooni/probe-engine

Comments

@bassosimone
Copy link
Contributor

During the SplinterCon demo (see ooni/probe-cli#1423), I noticed that we're not able to parse integer options from OONI Run v2 descriptors. This happens because they're parsed as float64 and the code that is setting options is confused by this fact, given that it only expects integers in input.
@bassosimone bassosimone added the bug Something isn't working label Dec 13, 2023
@bassosimone bassosimone self-assigned this Dec 13, 2023
@bassosimone bassosimone mentioned this issue Dec 13, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Dec 13, 2023
@bassosimone
fix: make sure we can parse integers from JSON (#1435)
86bea50 
This commit ensures we can parse integer values provided using OONI Run
v2 descriptors into actual integers.

Values are originally parsed as float64, so we need to add a specific
conversion case for that scenario.

Diff extracted from: #1423

Closes ooni/probe#2645
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix: make sure we can parse integers from JSON (ooni#1435)
b3c293d 
This commit ensures we can parse integer values provided using OONI Run
v2 descriptors into actual integers.

Values are originally parsed as float64, so we need to add a specific
conversion case for that scenario.

Diff extracted from: ooni#1423

Closes ooni/probe#2645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working funder/mozilla2023 ooni/probe-engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make sure we can parse integers from JSON ooni/probe-cli
1 participant
@bassosimone