Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: use two transactions for DNS over UDP or HTTPS lookups #2624

Open
bassosimone opened this issue Oct 31, 2023 · 0 comments
Open

engine: use two transactions for DNS over UDP or HTTPS lookups #2624

bassosimone opened this issue Oct 31, 2023 · 0 comments
Assignees
@bassosimone
Labels
bug Something isn't working data quality priority/low

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 31, 2023 •
edited
Loading

We should use two distinct transactions, otherwise we cannot correlate which I/O (or other operations) belong to which DNS lookup operations. This change would require some refactoring insider netxlite and measurexlite.

For example:

Screenshot 2023-10-31 at 15 50 54

See https://explorer.ooni.org/m/20231030145816.812438_IT_webconnectivity_57f0778d880c86a7
@bassosimone bassosimone self-assigned this Oct 31, 2023
@bassosimone bassosimone mentioned this issue Nov 28, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Nov 28, 2023
@bassosimone
fix(minipipeline): DNSLookupFailures must be a slice (#1395)
719c3c2 
`WebObservationsContainer.DNSLookupFailures` MUST be a slice because of
ooni/probe#2624. We have the same transaction
IDs for both A and AAAA queries. Until we fix this bug, we must use a
list because that allows for duplication.

While there, create `measurexlite.webTitleRegexp` just once.

While there, implement an `-help` flag for
`./internal/cmd/minipipeline`.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(minipipeline): DNSLookupFailures must be a slice (ooni#1395)
7e10550 
`WebObservationsContainer.DNSLookupFailures` MUST be a slice because of
ooni/probe#2624. We have the same transaction
IDs for both A and AAAA queries. Until we fix this bug, we must use a
list because that allows for duplication.

While there, create `measurexlite.webTitleRegexp` just once.

While there, implement an `-help` flag for
`./internal/cmd/minipipeline`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working data quality priority/low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone