Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dslx: introduce DNSLookupParallel #2617

Closed
bassosimone opened this issue Oct 25, 2023 · 0 comments · Fixed by ooni/probe-cli#1387
Closed

dslx: introduce DNSLookupParallel #2617

bassosimone opened this issue Oct 25, 2023 · 0 comments · Fixed by ooni/probe-cli#1387
Assignees
@bassosimone
Labels
enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/medium

Comments

@bassosimone
Copy link
Contributor

The dslx package is still more difficult to use than it should be. We should introduce a function named DNSLookupParallel that performs a parallel DNS lookup using some underlying DNS lookup functions and return aggregate results.

The overall objective here is to cleanup and review dslx, then start using it in production and rewrite experiments using it. In turn, by doing that, we'll enable collecting better throttling metrics for experiments.
@bassosimone bassosimone self-assigned this Oct 25, 2023
@bassosimone bassosimone added cleanup There's need to cleanup stuff a bit funder/drl2022-2024 ooni/probe-engine priority/medium refactoring techdebt This issue describes technical debt and removed refactoring labels Oct 25, 2023
@bassosimone bassosimone mentioned this issue Oct 25, 2023
Merged
@bassosimone bassosimone added enhancement improving existing code or new feature and removed techdebt This issue describes technical debt cleanup There's need to cleanup stuff a bit labels Oct 25, 2023
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 25, 2023
@bassosimone
feat(dslx): implement DNSLookupParallel (#1387)
420aadb 
Closes ooni/probe#2617

While there: there's no need to return the Trace used for DNS lookup and
there's no meaning in aggregating traces when running DNSLookupParallel,
because we have multiple traces, so let's just drop
ResolvedAddresses.Trace.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
feat(dslx): implement DNSLookupParallel (ooni#1387)
55c7891 
Closes ooni/probe#2617

While there: there's no need to return the Trace used for DNS lookup and
there's no meaning in aggregating traces when running DNSLookupParallel,
because we have multiple traces, so let's just drop
ResolvedAddresses.Trace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dslx): implement DNSLookupParallel ooni/probe-cli
1 participant
@bassosimone