Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: pass model.ExperimentArgs to Experiment.Run #2358

Closed
bassosimone opened this issue Nov 17, 2022 · 0 comments · Fixed by ooni/probe-cli#983
Closed

engine: pass model.ExperimentArgs to Experiment.Run #2358

bassosimone opened this issue Nov 17, 2022 · 0 comments · Fixed by ooni/probe-cli#983
Assignees
Labels
cleanup There's need to cleanup stuff a bit enhancement improving existing code or new feature funder/drl2020-2022 ooni/probe-engine priority/high refactoring

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Nov 17, 2022

This issue is a child of ooni/ooni.org#1292. The observation here is that we are passing to the Experiment's Run method individual arguments. This design choice makes it difficult to apply changes such as adding new, possibly-optional arguments to experiments, because we need to refactor each experiment. On the contrary, if we replace all the arguments with a structure containing the arguments, there's less friction and we can more easily apply changes. Once this change has been implemented, we'll be in a better position to pass richer input to experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup There's need to cleanup stuff a bit enhancement improving existing code or new feature funder/drl2020-2022 ooni/probe-engine priority/high refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant