Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: geolocate should not depend on engine/netx #2114

Closed
bassosimone opened this issue May 25, 2022 · 1 comment
Closed

cleanup: geolocate should not depend on engine/netx #2114

bassosimone opened this issue May 25, 2022 · 1 comment
Assignees
@bassosimone
Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/low refactoring techdebt This issue describes technical debt

Comments

@bassosimone
Copy link
Contributor

We are slowly migrating packages away from engine/netx and towards netxlite. The next package that should be migrated is the geolocate package, which is not using engine/netx in a complicated way, so it should be very easy to migrate.
@bassosimone bassosimone added priority/low refactoring ooni/probe-engine techdebt This issue describes technical debt cleanup There's need to cleanup stuff a bit labels May 25, 2022
@bassosimone bassosimone self-assigned this May 25, 2022
bassosimone added a commit to ooni/probe-cli that referenced this issue May 25, 2022
@bassosimone
cleanup(geolocate): use netxlite rather than netx
86790a8 
See ooni/probe#2114
@bassosimone bassosimone mentioned this issue May 25, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue May 25, 2022
@bassosimone
cleanup(geolocate): use netxlite rather than netx (#756)
09523f8 
See ooni/probe#2114
@bassosimone
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/low refactoring techdebt This issue describes technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone