Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new default bridge to OONI tests #1915

Closed
cohosh opened this issue Dec 9, 2021 · 4 comments
Closed

Add new default bridge to OONI tests #1915

cohosh opened this issue Dec 9, 2021 · 4 comments
Assignees

Comments

@cohosh
Copy link

cohosh commented Dec 9, 2021

We have a new default bridge in Tor Browser:

obfs4 185.100.85.3:443 5B403DFE34F4872EB027059CECAE30B0C864B3A2 cert=bWUdFUe8io9U6JkSLoGAvSAUDcB779/shovCYmYAQb/pW/iEAMZtO/lCd94OokOF909TPA iat-mode=2

Can we add this to the OONI Tor tests?

@cohosh cohosh added effort/M priority/medium Normal priority issue labels Dec 9, 2021
@cohosh cohosh changed the title Add new default bridges to OONI tests Add new default bridge to OONI tests Dec 9, 2021
@bassosimone bassosimone added the triage Should be triaged through the triage board label Dec 9, 2021
@bassosimone bassosimone added data quality ooni/probe-engine and removed triage Should be triaged through the triage board labels Jan 23, 2022
@hellais hellais removed the effort/M label Jan 31, 2022
@hellais
Copy link
Member

hellais commented Feb 3, 2022

@FedericoCeratto do you know which of these two tor-targets.json files need to be editted and where the deployment needs to happen: https://github.com/ooni/sysadmin/search?q=obfs4?

@bassosimone
Copy link
Contributor

bassosimone commented May 18, 2022

The work done by @hellais in ooni/sysadmin#495 should in principle add this bridge, however I just manually checked the output of https://bridges.torproject.org/moat/circumvention/builtin and I did not see such a bridge. So, I think this is a good moment to summon @meskio and double check our procedure here. To summarize/recap:

  1. The PR at Tor targets sysadmin#495 fetches bridges from https://bridges.torproject.org/moat/circumvention/builtin and writes to disk the files that, in turn, are served by the OONI API to OONI probes;

  2. Our understanding is that the https://bridges.torproject.org/moat/circumvention/builtin API serves bridges included in Tor Browser;

  3. So, I would have expected to see the bridge that @cohosh mentioned above inside https://bridges.torproject.org/moat/circumvention/builtin's output, but that's not the case;

  4. Now I am wondering whether (a) the above bridge is not part of Tor Browser anymore or (b) some of our assumptions are wrong.

@meskio
Copy link

meskio commented May 19, 2022

It looks like this bridge was removed in february:
https://gitweb.torproject.org/builders/tor-browser-build.git/commit/projects/tor-browser/Bundle-Data/PTConfigs/bridge_prefs.js?id=7789cee3b61c84af176dddb460a9e39f603c062f

The full list of obfs4 bridges in torbrowser is in this file (used to be bridge_prefs.js but got moved):
https://gitweb.torproject.org/builders/tor-browser-build.git/tree/projects/common/bridges_list.obfs4.txt

https://bridges.torproject.org/moat/circumvention/builtin does get the list from this file and provides it as a json.

@bassosimone
Copy link
Contributor

Awesome, thanks! So, we can close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants