Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update progress bar and time remaining behavior #475

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Update progress bar and time remaining behavior #475

merged 2 commits into from
Apr 7, 2022

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Mar 16, 2022 •
edited
Loading

bassosimone
bassosimone reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks okay except I think we should make the code robust against division by zero

bassosimone
bassosimone approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit 21c6219 into master Apr 7, 2022
@aanorbel aanorbel deleted the issues/2021 branch April 7, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@lorenzoPrimi lorenzoPrimi Awaiting requested review from lorenzoPrimi

@hellais hellais Awaiting requested review from hellais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

probe-mobile: improve progress bar of tests
2 participants
@aanorbel @bassosimone