Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce the tlsping experiment #716

Merged
merged 2 commits into from
May 9, 2022
Merged

feat: introduce the tlsping experiment #716

merged 2 commits into from
May 9, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented May 9, 2022

Checklist

Description

See ooni/probe#2088.

bassosimone added a commit to ooni/spec that referenced this pull request May 9, 2022
@bassosimone
Copy link
Contributor Author

bassosimone commented May 9, 2022

Here's the relevant failure for go1.17.9:

2022/05/09 08:16:54 error c.CheckReportID failed    error=httpx: request failed: 500 Internal Server Error
FAIL	github.com/ooni/probe-cli/v3/internal/cmd/apitool	0.605s

(See https://github.com/ooni/probe-cli/runs/6348156746?check_suite_focus=true#step:4:123)

This really seems another kind of unrelated issue, so it's safe to merge immediately.

Additionally, I've just run go test -race ./internal/cmd/apitool/... locally w/o errors so it was transient.

@bassosimone bassosimone merged commit 2917dd6 into master May 9, 2022
@bassosimone bassosimone deleted the issue/2088 branch May 9, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant