refactor: miniooni should be outside of the engine #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of ooni/probe#1335. We also need to think whether we wanna keep libminiooni and miniooni separated. The previous use case for having a top-level libminiooni was that of enabling others to integrate miniooni into other binaries. This was usegul when studying internet censorship in Spain in May 2020. I am wondering whether we should be keeping this complexity. I am not sure about this and probably we should be killing it. (In any case, reducing complexity is not the objective of this diff, since I would like instead to move things around with minimal changes and make sure we have a ~good repository organization here.)
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
* refactor: miniooni should be outside of the engine This is part of ooni/probe#1335. We also need to think whether we wanna keep libminiooni and miniooni separated. The previous use case for having a top-level libminiooni was that of enabling others to integrate miniooni into other binaries. This was usegul when studying internet censorship in Spain in May 2020. I am wondering whether we should be keeping this complexity. I am not sure about this and probably we should be killing it. (In any case, reducing complexity is not the objective of this diff, since I would like instead to move things around with minimal changes and make sure we have a ~good repository organization here.) * fix: import in libminiooni
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of ooni/probe#1335. We also need
to think whether we wanna keep libminiooni and miniooni separated.
The previous use case for having a top-level libminiooni was that of
enabling others to integrate miniooni into other binaries.
This was usegul when studying internet censorship in Spain in May 2020.
I am wondering whether we should be keeping this complexity. I am not
sure about this and probably we should be killing it.
(In any case, reducing complexity is not the objective of this diff,
since I would like instead to move things around with minimal changes
and make sure we have a ~good repository organization here.)