Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for returning measurement_uid as part of oonimkall API #1673

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Dec 7, 2024

Implements: ooni/probe#2521

@hellais hellais requested a review from DecFox as a code owner December 7, 2024 22:40
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have tested this with the probe-android repo and we can successfully expose the measurement_uid in the EventResult class through oonimkall.

@DecFox DecFox merged commit a0e3456 into master Dec 11, 2024
15 of 20 checks passed
@DecFox DecFox deleted the return-msmt-uid branch December 11, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants