Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dnscheck): gracefully cast to Target #1623

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix(dnscheck): gracefully cast to Target #1623

merged 2 commits into from
Jun 19, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Jun 19, 2024 •
edited
Loading

@bassosimone bassosimone marked this pull request as ready for review June 19, 2024 08:31
DecFox
DecFox approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bassosimone bassosimone merged commit 09b5750 into master Jun 19, 2024
19 checks passed
@bassosimone bassosimone deleted the issue/2753 branch June 19, 2024 08:44
@bassosimone bassosimone mentioned this pull request Jun 24, 2024
Merged
4 tasks
@bassosimone bassosimone added the 2024-06-richer-input Tracking 2024-06 richer input work label Jul 2, 2024
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecFox DecFox DecFox approved these changes

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
2024-06-richer-input Tracking 2024-06 richer input work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

engine: never unconditionally cast to richer input target
2 participants
@bassosimone @DecFox