chore: update psiphon #1522
Merged
chore: update psiphon #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems there's an issue by which some `replace` directives in the `go.mod` used by Psiphon aren't picked up by us. The thing is that `replace` only works for the main module. We thus asked for clarification before merging this PR. See ooni/probe#2690
36 tasks
|
I am going to merge, because I need this to understand whether we can intersect psiphon and snowflake as dependencies. I took note in the release check list of the implications of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there's an issue by which some
replacedirectives in thego.modused by Psiphon aren't picked up by us. The thing is thatreplaceonly works for the main module. We thus asked for clarification but we can merge this PR anyway, since it helps us to find dependency intersection between snowflake and psiphon (I am thinking mainly in terms of refraction-networking/utls).See ooni/probe#2690