feat(minipipeline): add metrics required by LTE compat analysis mode #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're introducing failure modes that do not exist hence it seems this is not the correct way of moving forward.
I'm doing this mainly to explore whether we could have more robust webconnectivity v0.5 analysis code
Because I am dropping the requests again, we break again the tests with the redirects. I could possibly fix it by putting requests back again but I am not super happy about doing this because that would cause the DSL to do some strange work and I'd honestly rather not do this.
what remains to be done now is to make sure we make green all the tests that are currently skipped we also need to account for differences between the two
then next step is to sort out this mess :-)
(I am thankful there's a ~comprehensive test suite.)
this happens because LTE sucessfully handshakes with the wrong address
bassosimone
changed the title
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
…oni#1415) This diff implements the following useful metrics: * DNSLookupSuccessWithValidAddress * DNSLookupSuccessWithValidAddressClassic * DNSLookupExpectedFailure * DNSLookupExpectedSuccess * HTTPFinalResponseSuccessTCPWithoutControl It also renames the HTTPDiff metrics for consistency, by adding an HTTPFinalResponse prefix to names. It also reimplements DNSExperimentFailure in terms of a generic DNS data collection function. And it also moves the definition of this variable to be near the top of the structure. I have also removed some tests. While in general this goes against my """religion""", I think I had added tests too prematurely and I need to move a bit faster to make this work converge. (Also, there are still several many tests that deal with producing data, which is why we have so much churn at every diff that changes the minipipeline. Also, the tests I am removing were only to cover corner cases, so I think it's overall justifiable to do this.) Part of ooni/probe#2634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff implements the following useful metrics:
It also renames the HTTPDiff metrics for consistency, by adding an HTTPFinalResponse prefix to names.
It also reimplements DNSExperimentFailure in terms of a generic DNS data collection function. And it also moves the definition of this variable to be near the top of the structure.
I have also removed some tests. While in general this goes against my """religion""", I think I had added tests too prematurely and I need to move a bit faster to make this work converge. (Also, there are still several many tests that deal with producing data, which is why we have so much churn at every diff that changes the minipipeline. Also, the tests I am removing were only to cover corner cases, so I think it's overall justifiable to do this.)
Part of ooni/probe#2634