dslx: post-Func.Apply(Maybe[T])-introduction cleanups #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
changed the title
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff contains cleanups in dslx after we modified Func.Apply to take a Maybe[T] as input: - we don't need anymore to record the failed operation because we can compute that inline, given that now we can write post-operation filters that observe whether the operation failed or succeeded; - likewise, we don't need to use counters anymore; - likewise, we can remove functions to inspect the first error, because we can compute that inline. The reference issue is ooni/probe#2613.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff contains cleanups in dslx after we modified Func.Apply to take a Maybe[T] as input:
we don't need anymore to record the failed operation because we can compute that inline, given that now we can write post-operation filters that observe whether the operation failed or succeeded;
likewise, we don't need to use counters anymore;
likewise, we can remove functions to inspect the first error, because we can compute that inline.
The reference issue is ooni/probe#2613.