fix(registry): disable vanilla_tor by default #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference issue is ooni/probe#2553. When I implemented the disabled-by-default functionality, I missed that we should also disable-by-default vanilla_tor. The reason for doing that is that the experiment crashes on Android and possibly iOS due to ooni/probe#2406.
bassosimone
added a commit
to ooni/backend
that referenced
this pull request
Oct 19, 2023
This is the counterpart of ooni/probe-cli#1374. Reference issue: ooni/probe#2553.
bassosimone
added a commit
that referenced
this pull request
Oct 19, 2023
This diff backports #1374 to release/3.19. The reference issue is ooni/probe#2553. When I implemented the disabled-by-default functionality, I missed that we should also disable-by-default vanilla_tor. The reason for doing that is that the experiment crashes on Android and possibly iOS due to ooni/probe#2406.
bassosimone
added a commit
to ooni/backend
that referenced
this pull request
Oct 20, 2023
This is the counterpart of ooni/probe-cli#1374. Reference issue: ooni/probe#2553.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
The reference issue is ooni/probe#2553. When I implemented the disabled-by-default functionality, I missed that we should also disable-by-default vanilla_tor. The reason for doing that is that the experiment crashes on Android and possibly iOS due to ooni/probe#2406.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference issue is ooni/probe#2553.
When I implemented the disabled-by-default functionality, I missed that we should also disable-by-default vanilla_tor.
The reason for doing that is that the experiment crashes on Android and possibly iOS due to ooni/probe#2406.