New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(enginenetx): more tests and robustness checks #1314

Merged

bassosimone merged 6 commits into master from issue/2531

Sep 26, 2023

Contributor

bassosimone commented Sep 26, 2023 •

edited

Loading

This diff attempts to improve the code quality of enginenetx by identifying cases where the code could be made to crash with specially written input and adds regress tests and checks to avoid these kind of crashes to happen.

While there, perform a code review and improve comments and naming.

Part of ooni/probe#2531


          chore(enginenetx): write more tests

cecaa83

This diff attempts to improve the code quality of enginenetx
by identifying cases where the code could be made to crash with
specially written input and adds regress tests and checks to
avoid these kind of crashes to happen.

While there, perform a code review and improve comments.

Part of ooni/probe#2531

bassosimone requested a review from hellais as a code owner

September 26, 2023 19:31

bassosimone commented

View reviewed changes

internal/enginenetx/beaconspolicy.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/enginenetx/beaconspolicy.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/enginenetx/httpsdialer.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/enginenetx/httpsdialer.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/enginenetx/staticpolicy.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/enginenetx/statspolicy.go Outdated Show resolved Hide resolved


          Apply suggestions from code review

aaec5f6

bassosimone changed the title ~~chore(enginenetx): write more tests~~ chore(enginenetx): more tests and robustness checks

1226f07

bassosimone commented

View reviewed changes

internal/enginenetx/statsmanager.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/enginenetx/statspolicy.go Outdated Show resolved Hide resolved

bassosimone added 3 commits

September 26, 2023 22:36


          Apply suggestions from code review

9a87823

f2964a8


          Merge branch 'issue/2531' of github.com:ooni/probe-cli into issue/2531

59a35f0

bassosimone merged commit eee7e71 into master

bassosimone deleted the issue/2531 branch

September 26, 2023 20:52

bassosimone mentioned this pull request

engine: adapt to use bridges ooni/probe#2531

Closed

Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request


          chore(enginenetx): more tests and robustness checks (ooni#1314)

217bbec

This diff attempts to improve the code quality of enginenetx by
identifying cases where the code could be made to crash with specially
written input and adds regress tests and checks to avoid these kind of
crashes to happen.

While there, perform a code review and improve comments and naming.

Part of ooni/probe#2531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet