fix(oohelperd): disable QUIC by default #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been eyeballing the performance charts for a few days and it seems that enabling QUIC makes measurements slower. The TH requires more time to complete. So, the probe can measure less target URLs per run, given finite runtime constraints. Measuring QUIC in the TH when the probe also measures QUIC is fine because we obtain higher quality measurements. However, now that most probes do not know about QUIC, it makes sense to avoid measuring QUIC for them, so they continue to measure the same number of URLs as before. This diff belongs to the not-ever-small set of diffs authored when doing pre-release QA. See ooni/probe#2273.
bassosimone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been eyeballing the performance charts for a few days and it seems that enabling QUIC makes measurements ~slower.
The TH requires more time to complete. So, the probe can measure less target URLs per run, given finite runtime constraints.
Measuring QUIC in the TH when the probe also measures QUIC is fine because we obtain higher quality measurements.
However, now that most probes do not know about QUIC, it makes sense to avoid measuring QUIC for them, so they continue to measure the same number of URLs as before.
This diff belongs to the not-ever-small set of diffs authored when doing pre-release QA. See ooni/probe#2273.