fix: avoid submitting when tor binary is missing #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff modifies tunnel, torsf, and vanilla such that: 1. we return a special error when tor is not found on PATH 2. we use such an error to avoid submitting By doing that, we save some useless submissions. Part of ooni/probe#2406 because I wrote this diff while investigating it.
|
Thanks @DecFox for finishing this pull request! 🙌 💯 🔝 🙏 |
|
I removed a test that is broken when |
bassosimone
added a commit
that referenced
this pull request
Jun 12, 2023
This diff backports e9cc324. This diff modifies tunnel, torsf, and vanilla such that: 1. we return a special error when tor is not found on PATH 2. we use such an error to avoid submitting By doing that, we save some useless submissions. Part of ooni/probe#2406 because I wrote this diff while investigating it. --------- Co-authored-by: DecFox <[email protected]>
cyBerta
pushed a commit
to cyBerta/probe-cli
that referenced
this pull request
Aug 4, 2023
This diff modifies tunnel, torsf, and vanilla such that: 1. we return a special error when tor is not found on PATH 2. we use such an error to avoid submitting By doing that, we save some useless submissions. Part of ooni/probe#2406 because I wrote this diff while investigating it. --------- Co-authored-by: DecFox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff modifies tunnel, torsf, and vanilla such that:
we return a special error when tor is not found on PATH
we use such an error to avoid submitting
By doing that, we save some useless submissions.
Part of ooni/probe#2406 because I wrote this diff while investigating it.