Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(probeservices): drop deprecated check_report_id API #1006

Merged
merged 3 commits into from
Dec 14, 2022
Merged

cleanup(probeservices): drop deprecated check_report_id API #1006

merged 3 commits into from
Dec 14, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Dec 14, 2022 •
edited
Loading

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request: probeservices: drop deprecated APIs probe#2380
  • if you changed anything related how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A
  • if you change code inside an experiment, make sure you bump its version number

Description

This diff drops the deprecated check_report_id API.

@bassosimone bassosimone marked this pull request as ready for review December 14, 2022 08:28
@bassosimone bassosimone requested a review from hellais as a code owner December 14, 2022 08:28
@bassosimone bassosimone merged commit ccbdc1b into master Dec 14, 2022
@bassosimone bassosimone deleted the issue/2380 branch December 14, 2022 08:35
@bassosimone bassosimone mentioned this pull request Dec 14, 2022
Merged
4 tasks
bassosimone added a commit that referenced this pull request Dec 14, 2022
@bassosimone
refactor(httpapi): API-specific descriptor initialization (#1009)
6d42be6 
The underlying rationale is that I want to annotate a Descriptor
with the request and response type, using generics.

Such a change will allow me to automatically generate a swagger
to compare to the one used by the OONI API.

Reference issue: ooni/probe#2362

While there, zap an integration test that I missed in
#1006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone