Skip to content

Commit

Permalink
Revert "fix(riseupvpn): skip currently failing tests (#212)"
Browse files Browse the repository at this point in the history
This reverts commit 43f95e2.

We can now safely close ooni/probe#1338,
since the upstream issue is gone. I think this issue we have seen is
also possibly related to ooni/probe#1348.

Cc: @cyBerta.
  • Loading branch information
bassosimone committed Feb 11, 2021
1 parent 18ca6d5 commit bf58097
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions internal/engine/experiment/riseupvpn/riseupvpn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ func TestNewExperimentMeasurer(t *testing.T) {
}

func TestGood(t *testing.T) {
t.Skip("broken test; see https://github.com/ooni/probe/issues/1338")
if testing.Short() {
t.Skip("skip test in short mode")
}
Expand Down Expand Up @@ -279,7 +278,6 @@ func TestFailureGeoIpServiceBlocked(t *testing.T) {
}

func TestFailureGateway(t *testing.T) {
t.Skip("broken test; see https://github.com/ooni/probe/issues/1338")
var testCases = [...]string{"openvpn", "obfs4"}
eipService, err := fetchEipService()
if err != nil {
Expand Down

0 comments on commit bf58097

Please sign in to comment.