Skip to content

Commit

Permalink
cleanup(buildtool): disable unit tests when building tor (#1368)
Browse files Browse the repository at this point in the history
We're building unit tests for no reason. Also, unit tests do not build
for iOS. So, let's stop building them.

Part of ooni/probe#2564
  • Loading branch information
bassosimone authored Oct 12, 2023
1 parent 76c140f commit 347e3cd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/cmd/buildtool/android_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1701,6 +1701,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
"--disable-tool-name-check",
"--disable-systemd",
"--prefix=/",
"--disable-unittests",
},
}, {
Env: []string{},
Expand Down Expand Up @@ -1777,6 +1778,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
"--disable-tool-name-check",
"--disable-systemd",
"--prefix=/",
"--disable-unittests",
},
}, {
Env: []string{},
Expand Down Expand Up @@ -1853,6 +1855,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
"--disable-tool-name-check",
"--disable-systemd",
"--prefix=/",
"--disable-unittests",
},
}, {
Env: []string{},
Expand Down Expand Up @@ -1929,6 +1932,7 @@ func TestAndroidBuildCdepsTor(t *testing.T) {
"--disable-tool-name-check",
"--disable-systemd",
"--prefix=/",
"--disable-unittests",
},
}, {
Env: []string{},
Expand Down
1 change: 1 addition & 0 deletions internal/cmd/buildtool/cdepstor.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ func cdepsTorBuildMain(globalEnv *cBuildEnv, deps buildtoolmodel.Dependencies) {
"--disable-tool-name-check",
"--disable-systemd",
"--prefix=/",
"--disable-unittests",
)
runtimex.Try0(shellx.RunEx(defaultShellxConfig(), argv, envp))

Expand Down
1 change: 1 addition & 0 deletions internal/cmd/buildtool/linuxcdeps_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ func TestLinuxCdepsBuildMain(t *testing.T) {
"--disable-tool-name-check",
"--disable-systemd",
"--prefix=/",
"--disable-unittests",
},
}, {
Env: []string{},
Expand Down

0 comments on commit 347e3cd

Please sign in to comment.