Display total "Time remaining counter" instead of single timer for single test

[aanorbel]

Fixes ooni/probe#1936

Proposed Changes

• Set TestRunBroadRequestReceiver.runtime to summation of TestAsyncTask.testSuites runtime.
• Set progress max value to equal previousTestsRuntime + currentTestProgress
• Calculate timeLeft from new values available.

.	.	.

[bassosimone]

My review could be broadly split into two parts:

1. I have asked for changes that overall seek to improve naming and documentation;

2. I have highlighted a bunch of places where I think we could possibly refactor and make the code a bit more abstract. I think they make sense but my limited Android skills could be failing me and I may be actually providing suggestions that make increase rather than decrease the complexity of the code. In which case, please, let me know and I'll keep in mind the lessons learned today for future reviews.

Thank you for preparing this diff!

[hellais]

The PR looks good to me. I did some light testing of it and I noticed the following two issues (that I believe are not related to this PR though):

When in dark mode the experimental icon has the wrong background color:

When in dark mode the status bar has the wrong color:

[aanorbel]

Hi @hellais , I will check the coloring for the progress bar.

[aanorbel]

Hello @hellais , this problem comes specifically from ExperimentalSuite() and anim/experimental.json which is not theme aware. I would have to make various changes at a later time to make the resource change with theme.

It is worth noting that this problem exists in all previous versions of the app.

[hellais]

Ok I documented the animation background color issue here: ooni/probe#2038. For the rest we can proceed with merging this!

[aanorbel]

Sure

[bassosimone]

🐳