This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Nervous system: nervous resolver that handles bogons #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not 100% sold yet on what is the actionable top-level event to in order to clarify in the log we've seen a bogon. Another good actionable idea could be to flag the presence of bogons (maybe along with DialID?) in MeasurementRoot, but this is also something I'd like to think about. This code in here is good for me to start understand it and then applying further changes as I get more insights.
bassosimone
added a commit
that referenced
this pull request
Oct 28, 2019
I am not 100% sold yet on what is the actionable top-level event to in order to clarify in the log we've seen a bogon. Another good actionable idea could be to flag the presence of bogons (maybe along with DialID?) in MeasurementRoot, but this is also something I'd like to think about. This code in here is good for me to start understand it and then applying further changes as I get more insights.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sold yet on what is the actionable top-level event
to in order to clarify in the log we've seen a bogon.
Another good actionable idea could be to flag the presence of
bogons (maybe along with DialID?) in MeasurementRoot, but this
is also something I'd like to think about.
This code in here is good for me to start understand it and then
applying further changes as I get more insights.
Master ticket is ooni/probe-engine#87