This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Make events actionable for OONI's nervous system #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trial and error, I have determined that, in general, to decide whether we need follow-up measurements, we need just the result of four events in the HTTP round trip: - RESOLVE_DONE - CONNECT - HANDSHAKE_DONE - ROUND_TRIP_DONE In some cases it may be possible to run operations inline while in others it's probably best to run concurrently or later. Regardless of the implementation strategy, this diff makes sure that by combining this four events only, we have enough information to conclude whether to trigger more measurements. This conclusion is based on my analysis using ooni/jafar, it may be of course that later we'll need to tweak this a bit. I've been doing refactoring for quite some time to prepare this. Master issue: ooni/probe-engine#87
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trial and error, I have determined that, in general, to decide
whether we need follow-up measurements, we need just the result of
four events in the HTTP round trip:
In some cases it may be possible to run operations inline while in
others it's probably best to run concurrently or later.
Regardless of the implementation strategy, this diff makes sure that
by combining this four events only, we have enough information to
conclude whether to trigger more measurements.
This conclusion is based on my analysis using ooni/jafar, it may be
of course that later we'll need to tweak this a bit.
I've been doing refactoring for quite some time to prepare this.
Master issue: ooni/probe-engine#87