feat: deploy ooniprobe service to prod #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @DecFox |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Fri, 19 Jul 2024 18:26:25 GMT |
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @DecFox |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Fri, 19 Jul 2024 15:55:49 GMT |
hellais
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
This looks good to me. One thing we should be careful of, however, is the values for the auto scaling group values: https://github.com/ooni/devops/blob/main/tf/environments/prod/main.tf#L283. I believe the current counts should be enough, but we should be cautious in this, since if we mess up the numbers there is the risk that we end up without enough resources to keep all the services online.
|
needed for ooni/probe#2781 |
hellais
reviewed
Jul 24, 2024
| source = "../../modules/ooniapi_service" | ||
|
|
||
| # First run should be set on first run to bootstrap the task definition | ||
| first_run = true |
There was a problem hiding this comment.
Be sure to flip this after first deploy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds the necessary terraform code to deploy
ooniprobebackend service to prod