Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebased willclose: Optimize performance of table writers and refactor table model #72

Closed
wants to merge 16 commits into from

Conversation

hellais
Copy link
Member

@hellais hellais commented May 1, 2024

superseeded by new PR

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 94.90085% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 83.54%. Comparing base (0ce4177) to head (d02e6b5).
Report is 1 commits behind head on pipeline-prod-debug.

Files Patch % Lines
oonidata/src/oonidata/models/base.py 76.19% 5 Missing ⚠️
oonipipeline/src/oonipipeline/db/create_tables.py 93.44% 4 Missing ⚠️
oonipipeline/src/oonipipeline/cli/commands.py 85.71% 2 Missing ⚠️
...onipipeline/analysis/website_experiment_results.py 66.66% 1 Missing ⚠️
oonipipeline/src/oonipipeline/db/connections.py 98.38% 1 Missing ⚠️
...c/oonipipeline/temporal/activities/observations.py 85.71% 1 Missing ⚠️
...oonipipeline/transforms/measurement_transformer.py 92.85% 1 Missing ⚠️
...nipipeline/transforms/nettests/web_connectivity.py 90.90% 1 Missing ⚠️
...peline/src/oonipipeline/transforms/observations.py 85.71% 1 Missing ⚠️
oonipipeline/tests/test_db.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           pipeline-prod-debug      #72      +/-   ##
=======================================================
+ Coverage                77.44%   83.54%   +6.10%     
=======================================================
  Files                       32       74      +42     
  Lines                     1893     6060    +4167     
=======================================================
+ Hits                      1466     5063    +3597     
- Misses                     427      997     +570     
Flag Coverage Δ
oonidata 77.35% <88.88%> (-0.09%) ⬇️
oonipipeline 86.39% <95.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellais hellais changed the title Table model refactor Optimize performance of table writers and refactor table model May 2, 2024
Base automatically changed from pipeline-prod-debug to main May 2, 2024 19:28
@hellais hellais changed the title Optimize performance of table writers and refactor table model Superseeded by #73 Jun 20, 2024
@hellais hellais changed the title Superseeded by #73 rebased willclose: Optimize performance of table writers and refactor table model Jun 20, 2024
@hellais hellais closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant