Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-in v1: return feature flags for experimental experiments #742

Closed
bassosimone opened this issue Oct 11, 2023 · 1 comment
Closed

check-in v1: return feature flags for experimental experiments #742

bassosimone opened this issue Oct 11, 2023 · 1 comment
Assignees
Labels
api API funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/high

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 11, 2023

In ooni/probe-cli#1355, we introduced the concept of experimental experiments. These are OONI experiments that the engine considers disabled unless a bypass environment variable is set or check-in has instructed the probe that it is allowed to use these experiments. (We cache the check-in flags for 24h.)

This issue is about enabling the experimental experiments using the check-in flags. In practical terms, we need to extend the feature flags to unconditionally include the following feature flags:

// This JSON contains a subset of how the whole check-in response should look like
{
  "conf": {
    "features": {
      "torsf_enabled": true
    }
  }
}

I marked torsf as disabled because potentially upcoming SNI changes in snowflake may require an emergency release to fix the SNI we are using. However, for the time being it should be enabled via the check-in API.

@bassosimone
Copy link
Contributor Author

We're good, let's close this issue as done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API funder/drl2022-2024 ooni/api Issues related to https://github.com/ooni/api priority/high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant