Skip to content

Commit

Permalink
fix(fbmessenger): attempt to improve data analysis
Browse files Browse the repository at this point in the history
Based on feedback from @hellais
  • Loading branch information
bassosimone committed Jun 1, 2023
1 parent 0d9b2e5 commit ed6a5df
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/experiment/fbmessenger/fbmessenger.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,11 @@ func (tk *TestKeys) update(consistent, reachable *optional.Value[bool], observat
// if not consistent, update DNS blocking.
if !consistent.IsNone() && !consistent.Unwrap() {
tk.FacebookDNSBlocking = optional.Some(true)
// TODO(bassosimone): we should make sure we're following the spirit of the spec,
// which the code below is trying to follow more closely.
tk.FacebookTCPBlocking = optional.Some(false)
*reachable = optional.Some(false)
return
}

// determine whether the TCP endpoint was reachable.
Expand Down

0 comments on commit ed6a5df

Please sign in to comment.