Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #6024, don't auto-hide the chat contents #6247

Merged
merged 62 commits into from
Jul 21, 2024
Merged

Fix for issue #6024, don't auto-hide the chat contents #6247

merged 62 commits into from
Jul 21, 2024

Conversation

Patronics
Copy link
Contributor

Comment out line to auto-hide scrollbar that causes issues by also hiding the text on the page, as described in #6024.
Of course as implemented so far this does remove the auto-hiding functionality of the scrollbar as well, further revisions are welcome.

Checklist:

@oobabooga
Merge pull request oobabooga#4927 from oobabooga/dev
c3e0fcf 
Merge dev branch
@oobabooga
Merge pull request oobabooga#4937 from oobabooga/dev
443be39 
Merge dev branch
@oobabooga
Merge pull request oobabooga#4961 from oobabooga/dev
7be0983 
Merge dev branch
@oobabooga
Merge pull request oobabooga#4980 from oobabooga/dev
b28020a 
Merge dev branch
@oobabooga
Merge pull request oobabooga#4988 from oobabooga/dev
781367b 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5002 from oobabooga/dev
71eb744 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5005 from oobabooga/dev
5b791ca 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5011 from oobabooga/dev
c1f78db 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5012 from oobabooga/dev
489f4a2 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5022 from oobabooga/dev
11288d1 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5039 from oobabooga/dev
4b25acf 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5073 from oobabooga/dev
af87609 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5078 from oobabooga/dev
19d1374 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5100 from oobabooga/dev
3fd7073 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5132 from oobabooga/dev
3e3a66e 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5152 from oobabooga/dev
3f28925 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5163 from oobabooga/dev
c54d1da 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5181 from oobabooga/dev
8ea3f31 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5195 from oobabooga/dev
e169993 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5199 from oobabooga/dev
ad1ff53 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5220 from oobabooga/dev
2dc8db8 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5253 from oobabooga/dev
61e4bfe 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5266 from oobabooga/dev
d8c3a5b 
Merge dev branch (oobabooga#5257)
@oobabooga
Merge pull request oobabooga#5347 from oobabooga/dev
1343aa3 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5348 from oobabooga/dev
837bd88 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5379 from oobabooga/dev
e7a760e 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5404 from oobabooga/dev
4f3fdf1 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5452 from oobabooga/dev
a329db0 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5453 from oobabooga/dev
0f134bf 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5496 from oobabooga/dev
dc6adef 
Merge dev branch
oobabooga and others added 22 commits March 10, 2024 23:39
@oobabooga
Merge pull request oobabooga#5680 from oobabooga/dev
1934cb6 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5716 from oobabooga/dev
7cf1402 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5772 from oobabooga/dev
1a7c027 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5810 from oobabooga/dev
5b91dbb 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5822 from oobabooga/dev
65099dc 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5823 from oobabooga/dev
91a7370 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5848 from oobabooga/dev
26d822f 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5887 from oobabooga/dev
a4b732c 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5927 from oobabooga/dev
ad12236 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5959 from oobabooga/dev
81f603d 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5970 from oobabooga/dev
8f12fb0 
Merge dev branch
@oobabooga
Merge pull request oobabooga#5996 from oobabooga/dev
9ac5287 
Merge dev branch
@oobabooga
Merge pull request oobabooga#6027 from oobabooga/dev
abe5ddc 
Merge dev branch
@oobabooga
Merge pull request oobabooga#6118 from oobabooga/dev
4820ae9 
Merge dev branch
@oobabooga
Merge pull request oobabooga#6166 from oobabooga/dev
6915c50 
Merge dev branch
@oobabooga
Make dependabot target the dev branch
2f71515
@oobabooga
Merge pull request oobabooga#6199 from oobabooga/dev
363efe5 
Merge dev branch
@oobabooga
Merge pull request oobabooga#6200 from oobabooga/dev
3315d00 
Merge dev branch
@oobabooga
Merge pull request oobabooga#6203 from oobabooga/dev
e813b32 
Merge dev branch
@oobabooga
Merge pull request oobabooga#6224 from oobabooga/dev
d01c68f 
Merge dev branch
@oobabooga
Merge pull request oobabooga#6232 from oobabooga/dev
0315122 
Merge dev branch
@Patronics
comment out auto-hide scrollbar line that mistakenly also hides the t…
6e60dd6 
…ext on the page
@oobabooga
Copy link
Owner

Removing the feature is not a good solution. I don't experience the reported flickering on my system. Can you try to figure out a workaround that works for you?

@Patronics
Copy link
Contributor Author

Okay, I just pushed an adjustment that reenables the auto-hide of the scrollbar, while keeping the chat (based on the prose class within chat-parent) visible!

@oobabooga oobabooga changed the base branch from main to dev July 21, 2024 03:04
@oobabooga
Copy link
Owner

Nice, thanks for the creative fix!

@oobabooga oobabooga merged commit 9b205f9 into oobabooga:dev Jul 21, 2024
PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Oct 22, 2024
@Patronics @PoetOnTheRun
Fix for issue oobabooga#6024, don't auto-hide the chat contents (ooba…
888efd7 
…booga#6247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patronics @oobabooga