Fix stopping strings for llama-3 and phi #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The chat doesn't work anymore, the model doesn't want to output anything. I reverted back to the latest dev commit 8aaa0a6 and it works now. |
oobabooga
added a commit
that referenced
this pull request
May 23, 2024
This reverts commit 5499bc9.
|
Yeah that wasn't a good solution. I have reverted it and am trying to think of a better way to reverse-engineer those jinja templates. ad54d52 |
PoetOnTheRun
pushed a commit
to PoetOnTheRun/text-generation-webui
that referenced
this pull request
Oct 22, 2024
PoetOnTheRun
pushed a commit
to PoetOnTheRun/text-generation-webui
that referenced
this pull request
Oct 22, 2024
This reverts commit 5499bc9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People who train models are very creative in trying to make their jinja templates as hard to work with as possible. This is an attempt at getting the stopping strings right.