Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grammar not support utf-8 resolve #5849 resolve #5865 #5900

Merged
merged 1 commit into from
May 19, 2024
Merged

fix: grammar not support utf-8 resolve #5849 resolve #5865 #5900

merged 1 commit into from
May 19, 2024
+31 −20

Conversation

A0nameless0man
Copy link
Contributor

@A0nameless0man A0nameless0man commented Apr 21, 2024 •
edited
Loading

resolve #5849
resolve #5865

Checklist:

example

word ::= ['.?!,:;\-\u4e00-\u9fff](['.?!,:;\-\u4e00-\u9fff]+ " ")*
phrasePattern ::= "*" word "*"
root ::= phrasePattern singleSpace word (singleSpace phrasePattern )?
singleSpace ::= " "

Reference

https://github.com/ggerganov/llama.cpp/blob/master/grammars/README.md#characters-and-character-ranges

@A0nameless0man A0nameless0man changed the base branch from main to dev April 21, 2024 16:11
@A0nameless0man A0nameless0man changed the title fix: grammar not support utf-8 fix: grammar not support utf-8 resolve #5849 resolve #5865 Apr 22, 2024
@A0nameless0man A0nameless0man changed the title fix: grammar not support utf-8 resolve #5849 resolve #5865 fix: grammar not support utf-8 Apr 22, 2024
@A0nameless0man A0nameless0man changed the title fix: grammar not support utf-8 fix: grammar not support utf-8 resolve #5849 resolve #5865 Apr 22, 2024
@oobabooga
Copy link
Owner

Amazing that you managed to fix this, thank you.

@oobabooga oobabooga merged commit 5cb5970 into oobabooga:dev May 19, 2024
anon-contributor-0 pushed a commit to anon-contributor-0/text-generation-webui that referenced this pull request May 30, 2024
@A0nameless0man @anon-contributor-0
fix: grammar not support utf-8 (oobabooga#5900)
98e06fe
PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Oct 22, 2024
@A0nameless0man @PoetOnTheRun
fix: grammar not support utf-8 (oobabooga#5900)
96b77ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A0nameless0man @oobabooga