Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Slot ids are misassigned on reallocation #504

Closed
lbradstreet opened this issue Jan 25, 2016 · 1 comment
Closed

Slot ids are misassigned on reallocation #504

lbradstreet opened this issue Jan 25, 2016 · 1 comment
Labels
scheduler

Comments

@lbradstreet
Copy link
Member

Similar to #503, except that the reallocated peers is also assigned a whole new slot-id, 1, rather than slot-id 0, which is the correct slot given that there is only one peer allocated to the task.

This causes the windowing/state-management to break, as a task's state becomes split over multiple slots.
lbradstreet added a commit that referenced this issue Jan 25, 2016
@lbradstreet
Fix incorrect slot-id allocation #504
7de443b 
Caused by not doing a de-allocation pass before an allocation pass.
This meant that a slot that should be taken by an allocation was not
available when the allocation occurred before the deallocation.
@lbradstreet
Copy link
Member Author

Fixed. Closing.

@lbradstreet lbradstreet mentioned this issue Jan 25, 2016
Closed
lbradstreet added a commit that referenced this issue Jan 26, 2016
@lbradstreet
Fix incorrect slot-id allocation #504
a66584e 
Caused by not doing a de-allocation pass before an allocation pass.
This meant that a slot that should be taken by an allocation was not
available when the allocation occurred before the deallocation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scheduler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lbradstreet