Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

State/windowing CPU usage is dominated by alts!! calls #500

Closed
lbradstreet opened this issue Jan 23, 2016 · 1 comment
Closed

State/windowing CPU usage is dominated by alts!! calls #500

lbradstreet opened this issue Jan 23, 2016 · 1 comment
Assignees
@lbradstreet
Labels
performance state/windowing

Comments

@lbradstreet
Copy link
Member

Seeing this in jepsen runs where we have all windowing passed through a single peer. As a result, await-job-completion times out after 20 minutes and the test is failed.

Most of the time is spent calling alts!! which has incredibly bad performance. I suggest we switch to using the internal impl function closed? to check whether the task-kill-ch and shutdown-ch channels are closed, and poll! to fetch from the write batch.
@lbradstreet lbradstreet self-assigned this Jan 23, 2016
@lbradstreet lbradstreet mentioned this issue Jan 23, 2016
Closed
@lbradstreet
Copy link
Member Author

Greatly improved in develop.

lbradstreet added a commit that referenced this issue Jan 25, 2016
@lbradstreet
Failed BookKeeper writes now reboot the peer #390
4d3684e 
Also closes #500 by improving performance of write-take-batch
lbradstreet added a commit that referenced this issue Jan 26, 2016
@lbradstreet
Failed BookKeeper writes now reboot the peer #390
6694e2a 
Also closes #500 by improving performance of write-take-batch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lbradstreet lbradstreet

Labels
performance state/windowing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lbradstreet