Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logotypes where feasible #3478

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Use logotypes where feasible #3478

merged 3 commits into from
Dec 17, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 15, 2024 •
edited
Loading

Description

Use logotype where possible
Screenshot 2024-12-16 at 4 34 43 PM

Screenshot 2024-12-16 at 4 29 54 PM Screenshot 2024-12-16 at 4 29 58 PM Screenshot 2024-12-16 at 4 30 02 PM Screenshot 2024-12-16 at 4 30 06 PM Screenshot 2024-12-16 at 4 25 42 PM Screenshot 2024-12-16 at 4 34 38 PM

How Has This Been Tested?

With these

  • Default logotype
  • Custom application name
  • Custom logo

Do the following:

  • Look at chat page
  • Look at admin page
  • Mobile view
  • Toggle between chat/admin (+ verify no jump0

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel Vercel
Copy link

vercel bot commented Dec 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 1:42am

@pablonyx pablonyx enabled auto-merge December 17, 2024 01:40
@pablonyx pablonyx added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit ed9014f Dec 17, 2024
11 of 13 checks passed
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
@pablonyx
Use logotypes where feasible (onyx-dot-app#3478)
162fe26 
* Use logotypes where feasible

* quick nit

* minor cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhongsun96 yuhongsun96 yuhongsun96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @yuhongsun96