Max File Size #3422
Merged
Max File Size #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
reviewed
Dec 10, 2024
|
|
||
| # Maximum file size in a document to be indexed | ||
| MAX_DOCUMENT_CHARS = int(os.environ.get("MAX_DOCUMENT_CHARS") or 5000000) |
There was a problem hiding this comment.
nit: prefer 5_000_000 for readability!
Weves
reviewed
Dec 10, 2024
| # Maximum file size in a document to be indexed | ||
| MAX_DOCUMENT_CHARS = int(os.environ.get("MAX_DOCUMENT_CHARS") or 5000000) | ||
| MAX_FILE_SIZE_BYTES = int( | ||
| os.environ.get("MAX_FILE_SIZE_BYTES") or 5 * 1024 * 1024 |
Weves
approved these changes
Dec 10, 2024
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Dec 23, 2024
* k * k * k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicit handling for Google Drive
General catchall for all documents after they are processed into an Onyx Document. This must be done after the translation into text already because there is no other central place before this (and after pulling the file).
This addresses the container running out of memory. This is likely downstream of the catchall, possibly in the text processing (tokenizing) step.
How Has This Been Tested?
Unit test added
Tested Google Drive files manually with new configured limit
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.