Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector page lists (pending feedback) #3415

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 10, 2024

Description

Fixes https://linear.app/danswer/issue/DAN-1152/fix-connector-page-ugly

Screen.Recording.2024-12-10.at.1.49.25.PM.mov

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:18pm

@pablonyx pablonyx changed the title v1 (pending feedback) Connector page lists (pending feedback) Dec 10, 2024
@pablonyx pablonyx marked this pull request as draft December 10, 2024 20:09
@pablonyx pablonyx marked this pull request as ready for review December 10, 2024 21:50
@yuhongsun96
Copy link
Contributor

  • The text isn't actually aligned to the right, it's like left aligned in a box that's right aligned. This causes some visual issues
  • The text jumps around based on the show less/more if it's longer than the text in the box. It should just never jump around like that

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hagen-danswer hagen-danswer added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 637404f Dec 11, 2024
13 checks passed
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants