Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean citation cards #3396

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Clean citation cards #3396

merged 4 commits into from
Dec 11, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 10, 2024

Description

Screen.Recording.2024-12-10.at.4.59.35.PM.mov

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:40pm

@pablonyx pablonyx marked this pull request as draft December 10, 2024 22:18
@pablonyx pablonyx changed the title initial steps Clean citation cards Dec 11, 2024
@pablonyx pablonyx marked this pull request as ready for review December 11, 2024 01:03
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to Yuhong about it, we think the whole card should be clickable!

the value add of being able to copy the half sentence out of the citation is outweighed by the value of making it easier for the user to discover the clicking action of the citation

Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@pablonyx pablonyx enabled auto-merge December 11, 2024 17:36
@pablonyx pablonyx added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 11, 2024
@pablonyx pablonyx force-pushed the improved_citation_cards branch from 405782a to 1ccf72e Compare December 11, 2024 19:31
@pablonyx pablonyx force-pushed the improved_citation_cards branch from 1ccf72e to 5bee671 Compare December 11, 2024 19:32
@pablonyx pablonyx enabled auto-merge December 11, 2024 19:34
@pablonyx pablonyx added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@pablonyx pablonyx added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 72b4e8e Dec 11, 2024
12 of 13 checks passed
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
* seed

* initial steps

* clean up

* fully clickable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants