Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up csv prompt + frontend #3393

Merged
merged 5 commits into from
Dec 11, 2024
Merged

clean up csv prompt + frontend #3393

merged 5 commits into from
Dec 11, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 10, 2024 •
edited
Loading

Description

Fixes https://linear.app/danswer/issue/DAN-1017/csv-upload-no-error-message

Additional "uploading" chat state

Screenshot 2024-12-11 at 10 38 23 AM

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 6:52pm

hagen-danswer
hagen-danswer requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to upload large files and then chat with them causes a bad state for the chat window that bypasses this check

hagen-danswer
hagen-danswer approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i made another ticket to fix the slowness to chat with tooooo big of documents (but this works fine for docs that are just too large for the context)

@hagen-danswer hagen-danswer added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit e7a7e78 Dec 11, 2024
13 checks passed
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
@pablonyx
clean up csv prompt + frontend (onyx-dot-app#3393)
1e37dfa 
* clean up csv prompt + frontend

* nit

* nit

* detect uploading

* upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagen-danswer hagen-danswer hagen-danswer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @hagen-danswer