Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining Search and Chat Backend #3273

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Combining Search and Chat Backend #3273

merged 5 commits into from
Dec 3, 2024

Conversation

yuhongsun96
Copy link
Contributor

@yuhongsun96 yuhongsun96 commented Nov 27, 2024

Description

  • Combining Search and Chat flows
  • Removing one off logic for the old one-shot flows
  • Cleaning up dead code
  • Restructuring repo for extending it with agent style functionality
  • Cleaner abstractions and function layouts

How Has This Been Tested?

Needs significant testing across all major flows.

Accepted Risk (provide if relevant)

  • Search queries receive a name in chat history only after user clicks on it.
  • Very minor changes to APIs not used by frontend, may need to give a few users heads up

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 10:13pm


return context_data_list, answer
return [], ""
# TODO reenable with chat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add in this one? It should be pretty easy based on the rest of the PR

@hagen-danswer hagen-danswer marked this pull request as ready for review December 2, 2024 23:43
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably uncomment out that test!

@yuhongsun96 yuhongsun96 enabled auto-merge December 3, 2024 22:11
@yuhongsun96 yuhongsun96 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit aa1c4c6 Dec 3, 2024
9 of 10 checks passed
@hagen-danswer hagen-danswer deleted the refactor branch December 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants