Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CSV display #3028

Merged
merged 6 commits into from
Nov 3, 2024
Merged

add CSV display #3028

merged 6 commits into from
Nov 3, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Nov 2, 2024

Description

[Provide a brief description of the changes in this PR]

Screen.Recording.2024-11-02.at.12.32.01.PM.mov

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 6:41pm

@pablonyx pablonyx marked this pull request as ready for review November 3, 2024 17:49
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think the windows should be bigger to be usable.

Think about being an information worker that uses CSVs. what value are they getting out of this feature?

If i click the CSV and a tiny window pops up that isn't really readable so i have to download the CSV to tell whats goin on, i might as well just download it from the get-go.

Also its not very obvious that this feature exists when i upload a csv. There are the little expand arrows but i would argue that it isnt clear that this behavior exists.

so maybe start as a smaller version of the expanded view and then offer an expand window button that displays the larger view of the csv

@pablonyx
Copy link
Contributor Author

pablonyx commented Nov 3, 2024

Fair points! Updated

Screen.Recording.2024-11-03.at.10.41.20.AM.mov

@pablonyx pablonyx merged commit a7002df into main Nov 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants