-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CSV display #3028
add CSV display #3028
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think the windows should be bigger to be usable.
Think about being an information worker that uses CSVs. what value are they getting out of this feature?
If i click the CSV and a tiny window pops up that isn't really readable so i have to download the CSV to tell whats goin on, i might as well just download it from the get-go.
Also its not very obvious that this feature exists when i upload a csv. There are the little expand arrows but i would argue that it isnt clear that this behavior exists.
so maybe start as a smaller version of the expanded view and then offer an expand window button that displays the larger view of the csv
Fair points! Updated Screen.Recording.2024-11-03.at.10.41.20.AM.mov |
Description
[Provide a brief description of the changes in this PR]
Screen.Recording.2024-11-02.at.12.32.01.PM.mov
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.