Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest NextJS + switch to turbopack #3027

Merged
merged 10 commits into from
Nov 3, 2024
Merged

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Nov 2, 2024

Much faster page loading during dev!

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 11:03pm

@Weves Weves force-pushed the switch-to-turbopack branch from 196a778 to 4d3fdba Compare November 2, 2024 00:18
"/admin/standard-answer/:path*",

// Cloud only
"/admin/cloud-settings/:path*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason to not just include this anyways

@@ -10,7 +10,6 @@ const { withSentryConfig } = require("@sentry/nextjs");
/** @type {import('next').NextConfig} */
const nextConfig = {
output: "standalone",
swcMinify: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not recognized anymore

@@ -71,5 +73,8 @@
"eslint": "^8.48.0",
"eslint-config-next": "^14.1.0",
"prettier": "2.8.8"
},
"overrides": {
"react-is": "^19.0.0-rc-69d4b800-20241021"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to support shadcn charts with nextjs 15

https://ui.shadcn.com/docs/react-19

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit messy since we haven't switched to use react19, but it seems to work 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without it, the charts are empty

@pablonyx
Copy link
Contributor

pablonyx commented Nov 2, 2024

Seeing a couple small issues - specifically when trying to import the base tailwind themes

Module not found
   3 | const baseThemes = require("./tailwind-themes/tailwind.config.js");
   4 | const customThemes = process.env.NEXT_PUBLIC_THEME
>  5 |   ? require(
     |     ^^^^^^^^
>  6 |       `./tailwind-themes/custom/${process.env.NEXT_PUBLIC_THEME}/tailwind.config.js`
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  7 |     )
     | ^^^^^^
   8 |   : null;
   9 |
  10 | /** @type {import('tailwindcss').Config} */

and on the chat + admin pages- Accessing element.ref was removed in React 19. ref is now a regular prop. It will be removed from the JSX Element type in a future release.

@Weves Weves added this pull request to the merge queue Nov 3, 2024
@Weves Weves removed this pull request from the merge queue due to a manual request Nov 3, 2024
@Weves Weves added this pull request to the merge queue Nov 3, 2024
Merged via the queue into main with commit 938d578 Nov 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants