Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Mediawiki Tests #3005

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Disable Mediawiki Tests #3005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions backend/tests/unit/danswer/connectors/mediawiki/test_mediawiki_family.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@

from danswer.connectors.mediawiki import family


# Disabling these tests as they are flaky and rely on external wikis that are maintained by just fan communities


NON_BUILTIN_WIKIS: Final[list[tuple[str, str]]] = [
("https://fallout.fandom.com", "falloutwiki"),
("https://harrypotter.fandom.com/wiki/", "harrypotterwiki"),
Expand All @@ -19,6 +23,7 @@


# TODO: Add support for more builtin family types from `pywikibot.families`.
@pytest.mark.skip(reason="Temporarily skipped")
@pytest.mark.parametrize(
"url, name, expected",
[
Expand Down Expand Up @@ -48,6 +53,7 @@ def test_family_class_dispatch_builtins(
assert family.family_class_dispatch(url, name) == expected


@pytest.mark.skip(reason="Temporarily skipped")
@pytest.mark.parametrize("url, name", NON_BUILTIN_WIKIS)
def test_family_class_dispatch_on_non_builtins_generates_new_class_fast(
url: str, name: str, mocker: MockFixture
Expand All @@ -58,6 +64,7 @@ def test_family_class_dispatch_on_non_builtins_generates_new_class_fast(
mock_generate_family_class.assert_called_once_with(url, name)


@pytest.mark.skip(reason="Temporarily skipped")
@pytest.mark.slow
@pytest.mark.parametrize("url, name", NON_BUILTIN_WIKIS)
def test_family_class_dispatch_on_non_builtins_generates_new_class_slow(
Expand Down
Loading