Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/indexing logs #3002

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Feature/indexing logs #3002

merged 2 commits into from
Oct 31, 2024

Conversation

rkuo-danswer
Copy link
Contributor

@rkuo-danswer rkuo-danswer commented Oct 30, 2024

Description

Fixes DAN-905. Adds extra logging around indexing startup and completion.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:57pm

@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 30, 2024 23:21
@hagen-danswer hagen-danswer added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 231ab3f Oct 31, 2024
7 checks passed
rkuo-danswer added a commit that referenced this pull request Oct 31, 2024
* improve logging around indexing tasks

* task_logger doesn't work inside the spawned task
@hagen-danswer hagen-danswer deleted the feature/indexing_logs branch October 31, 2024 22:57
@hagen-danswer hagen-danswer restored the feature/indexing_logs branch October 31, 2024 22:57
@hagen-danswer hagen-danswer deleted the feature/indexing_logs branch October 31, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants