Fix file too large error #2799
Merged
Fix file too large error #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue in the Google Drive connector where large files (.doc, .ppt, or spreadsheets over 5MB) caused failures due to API limitations.
- Modified
_fetch_docs_from_drivemethod inbackend/danswer/connectors/google_drive/connector.pyto handle export-related errors - Implemented graceful skipping of files exceeding 5MB limit for specific file types
- Enhanced error handling to prevent connector failure on oversized files
- Improved robustness of the Google Drive connector for processing large document sets
- Resolved user-reported issue from Slack (link provided in PR description)
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
479
to
484
| # these errors don't represent a failure in the connector, but simply files | ||
| # that can't / shouldn't be indexed | ||
| ERRORS_TO_CONTINUE_ON = [ | ||
| "cannotExportFile", | ||
| "exportSizeLimitExceeded", | ||
| ] |
There was a problem hiding this comment.
style: Consider adding a constant or enum for these error types to improve maintainability
rkuo-danswer
approved these changes
Oct 14, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously would fail for .doc, .ppt, or spreadsheets that are over 5MB due to an API limitation.
https://danswer.slack.com/archives/C056265VB1N/p1728895185750569