Remove dev update #2795
Merged
Remove dev update #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the SERVER_SIDE_ONLY__CLOUD_ENABLED constant in web/src/lib/constants.ts to align server-side cloud feature enablement with client-side configurations.
- Changed
SERVER_SIDE_ONLY__CLOUD_ENABLEDto useNEXT_PUBLIC_CLOUD_ENABLEDenvironment variable - Allows for more flexible configuration of cloud features across the application
- Ensures consistency between server-side and client-side cloud feature enablement
- May require updates to application logic to handle cases where cloud features are disabled
- Developers should verify that all cloud-dependent features gracefully handle disabled state
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+64
to
+65
| export const SERVER_SIDE_ONLY__CLOUD_ENABLED = | ||
| process.env.NEXT_PUBLIC_CLOUD_ENABLED?.toLowerCase() === "true"; |
There was a problem hiding this comment.
style: Consider renaming to avoid confusion with client-side CLOUD_ENABLED constant
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: