Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing model server port for warmup #2767

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix indexing model server port for warmup #2767

merged 1 commit into from
Oct 11, 2024

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Oct 11, 2024

^

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 4:11am

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses a critical issue by fixing the server port used for the indexing model server warmup in the background update process.

  • Modified backend/danswer/background/update.py to use INDEXING_MODEL_SERVER_PORT instead of MODEL_SERVER_PORT
  • Ensures correct port usage for the indexing model server, crucial for proper indexing functionality
  • Minimal change reduces risk of introducing new issues while solving the port mismatch problem

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weves Weves added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 35d32ea Oct 11, 2024
7 checks passed
@Weves Weves deleted the fix-server-port branch October 18, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants